You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tree: 1e0bbbf20f

xmkb

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from '1e0bbbf20f'

${ noResults }

zmk/app/tests

History

Pete Johanson b7f6f313eb fix(behaviors): Fixing erroneous combo triggering, hold-taps sticking ... * This is a very simple fix to a rather complicated issue. Essentially, hold-taps will "release" (raise) their captured keys before actually telling the event manager they have captured a key. This means the event manager ends up assigning the `last_listener_index` to the hold-tap subscription rather than the combo. So when the combo calls `ZMK_EVENT_RELEASE` it raises after the hold-tap instead of after the combo as the combo code expects. * The corresponding test (which fails without this change) has also been added. * An event can be captured and released in the same event handler, before the last_listener_index would have been updated. This causes some handlers to be triggered multiple times. * The solution is to update the last_listener_index before calling the next event handler, so capturing and releasing within an event handler is harmless. * Also see discussion at https://github.com/zmkfirmware/zmk/pull/1401 * If our handler dedides our undedided hold-tap, return early before continuing. * Fix incorrect pointer logic, resulting in combo candidate filtering leaving incorrect timeout details. Co-authored-by: Andrew Rae <ajrae.nv@gmail.com> Co-authored-by: okke <okke@formsma.nl>		2 years ago
..
backlight	refactor(kscan): Auto enable kscan drivers	3 years ago
caps-word	feat(behaviors): Continue on mods in caps word.	3 years ago
combo	fix(behaviors): Fixing erroneous combo triggering, hold-taps sticking	2 years ago
conditional-layer	fix(keymaps): Handle matching `then-layer`s.	3 years ago
gresc	refactor(tests): Move to native_posix_64 target.	3 years ago
hold-tap	fix(tests): Fix hex formatting.	3 years ago
key-repeat	refactor(tests): Move to native_posix_64 target.	3 years ago
keypress	refactor(tests): Move to native_posix_64 target.	3 years ago
keytoggle	test(behavior): Add alt-tab test and modded alpha test for toggle key	3 years ago
macros	refactor(tests): Move to native_posix_64 target.	3 years ago
modifiers	refactor(tests): Move to native_posix_64 target.	3 years ago
momentary-layer	refactor(tests): Move to native_posix_64 target.	3 years ago
none	refactor(tests): Move to native_posix_64 target.	3 years ago
sticky-keys	refactor(tests): Move to native_posix_64 target.	3 years ago
tap-dance	refactor(tests): Move to native_posix_64 target.	3 years ago
to-layer	refactor(tests): Move to native_posix_64 target.	3 years ago
toggle-layer	refactor(tests): Move to native_posix_64 target.	3 years ago
transparent	refactor(tests): Move to native_posix_64 target.	3 years ago
wpm	refactor(kscan): Auto enable kscan drivers	3 years ago