You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tree: 1e0bbbf20f

xmkb

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from '1e0bbbf20f'

${ noResults }

zmk/app

History

Pete Johanson b7f6f313eb fix(behaviors): Fixing erroneous combo triggering, hold-taps sticking ... * This is a very simple fix to a rather complicated issue. Essentially, hold-taps will "release" (raise) their captured keys before actually telling the event manager they have captured a key. This means the event manager ends up assigning the `last_listener_index` to the hold-tap subscription rather than the combo. So when the combo calls `ZMK_EVENT_RELEASE` it raises after the hold-tap instead of after the combo as the combo code expects. * The corresponding test (which fails without this change) has also been added. * An event can be captured and released in the same event handler, before the last_listener_index would have been updated. This causes some handlers to be triggered multiple times. * The solution is to update the last_listener_index before calling the next event handler, so capturing and releasing within an event handler is harmless. * Also see discussion at https://github.com/zmkfirmware/zmk/pull/1401 * If our handler dedides our undedided hold-tap, return early before continuing. * Fix incorrect pointer logic, resulting in combo candidate filtering leaving incorrect timeout details. Co-authored-by: Andrew Rae <ajrae.nv@gmail.com> Co-authored-by: okke <okke@formsma.nl>		2 years ago
..
boards	feat(shields) add support for Spaceman Pancake (#1400)	2 years ago
cmake	fix(build): Fix for proper string variable check.	2 years ago
drivers	refactor(display): Move clear to unblank for EPD driver.	2 years ago
dts	fix(behaviors): Fix mod morph description	2 years ago
include	feat(behavior): Add key toggle	3 years ago
scripts	chore: make west scripts more pythonic and apply Black	3 years ago
src	fix(behaviors): Fixing erroneous combo triggering, hold-taps sticking	2 years ago
tests	fix(behaviors): Fixing erroneous combo triggering, hold-taps sticking	2 years ago
.gitignore	feat(metadata): Add YAML check/format npm scripts.	3 years ago
.prettierrc.js	feat(metadata): Add YAML check/format npm scripts.	3 years ago
CMakeLists.txt	refactor(build): Fixes for config/overlay loading.	3 years ago
Kconfig	feat(underglow): Add RGB auto off timeout on idle and on usb disconnect	2 years ago
core-coverage.yml	chore: Add Hummingbiard/XIAO BLE to core coverage.	3 years ago
package-lock.json	feat(metadata): Add YAML check/format npm scripts.	3 years ago
package.json	feat(metadata): Add YAML check/format npm scripts.	3 years ago
prj.conf	Removed development files	4 years ago
run-test.sh	refactor(tests): Use GH Actions matrix for tests.	3 years ago
west.yml	fix: Don't exclude segger, needed for DKs.	2 years ago