You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Branch: xmkb

xmkb

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from 'xmkb'

${ noResults }

zmk/app/tests/combo

History

Pete Johanson b7f6f313eb fix(behaviors): Fixing erroneous combo triggering, hold-taps sticking ... * This is a very simple fix to a rather complicated issue. Essentially, hold-taps will "release" (raise) their captured keys before actually telling the event manager they have captured a key. This means the event manager ends up assigning the `last_listener_index` to the hold-tap subscription rather than the combo. So when the combo calls `ZMK_EVENT_RELEASE` it raises after the hold-tap instead of after the combo as the combo code expects. * The corresponding test (which fails without this change) has also been added. * An event can be captured and released in the same event handler, before the last_listener_index would have been updated. This causes some handlers to be triggered multiple times. * The solution is to update the last_listener_index before calling the next event handler, so capturing and releasing within an event handler is harmless. * Also see discussion at https://github.com/zmkfirmware/zmk/pull/1401 * If our handler dedides our undedided hold-tap, return early before continuing. * Fix incorrect pointer logic, resulting in combo candidate filtering leaving incorrect timeout details. Co-authored-by: Andrew Rae <ajrae.nv@gmail.com> Co-authored-by: okke <okke@formsma.nl>		2 years ago
..
combos-and-holdtaps-0	refactor(tests): Move to native_posix_64 target.	2 years ago
combos-and-holdtaps-1	refactor(tests): Move to native_posix_64 target.	2 years ago
combos-and-holdtaps-2	refactor(tests): Move to native_posix_64 target.	2 years ago
combos-and-holdtaps-3	fix(behaviors): Fixing erroneous combo triggering, hold-taps sticking	2 years ago
combos-and-holdtaps-4	fix(behaviors): Fixing erroneous combo triggering, hold-taps sticking	2 years ago
layer-filter-0	refactor(tests): Move to native_posix_64 target.	2 years ago
layer-filter-1	refactor(tests): Move to native_posix_64 target.	2 years ago
multiple-timeouts	refactor(tests): Move to native_posix_64 target.	2 years ago
overlapping-combos-0	refactor(tests): Move to native_posix_64 target.	2 years ago
overlapping-combos-1	refactor(tests): Move to native_posix_64 target.	2 years ago
overlapping-combos-2	refactor(tests): Move to native_posix_64 target.	2 years ago
overlapping-combos-3	refactor(tests): Move to native_posix_64 target.	2 years ago
partially-overlapping-combos	refactor(tests): Move to native_posix_64 target.	2 years ago
press-release	refactor(tests): Move to native_posix_64 target.	2 years ago
press-release-long-combo-complete	refactor(tests): Move to native_posix_64 target.	2 years ago
press-release-long-combo-incomplete	refactor(tests): Move to native_posix_64 target.	2 years ago
press-release-long-combo-wrong-last-key	refactor(tests): Move to native_posix_64 target.	2 years ago
press-timeout	refactor(tests): Move to native_posix_64 target.	2 years ago
press1-press2-release1-release2	refactor(tests): Move to native_posix_64 target.	2 years ago
press1-press2-release2-release1	refactor(tests): Move to native_posix_64 target.	2 years ago
press1-release1-press2-release2	refactor(tests): Move to native_posix_64 target.	2 years ago
slowrelease-disabled	refactor(tests): Move to native_posix_64 target.	2 years ago
slowrelease-enabled	refactor(tests): Move to native_posix_64 target.	2 years ago