Browse Source

fix(behaviors): Prevent accidental transparent behavior return values.

Needed because k_work_reschedule can return positive success codes.
xmkb
DoctorNefario 3 years ago committed by GitHub
parent
commit
20a72263b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      app/src/ext_power_generic.c
  2. 3
      app/src/rgb_underglow.c

3
app/src/ext_power_generic.c

@ -50,7 +50,8 @@ static struct k_work_delayable ext_power_save_work;
int ext_power_save_state() { int ext_power_save_state() {
#if IS_ENABLED(CONFIG_SETTINGS) #if IS_ENABLED(CONFIG_SETTINGS)
return k_work_reschedule(&ext_power_save_work, K_MSEC(CONFIG_ZMK_SETTINGS_SAVE_DEBOUNCE)); int ret = k_work_reschedule(&ext_power_save_work, K_MSEC(CONFIG_ZMK_SETTINGS_SAVE_DEBOUNCE));
return MIN(ret, 0);
#else #else
return 0; return 0;
#endif #endif

3
app/src/rgb_underglow.c

@ -272,7 +272,8 @@ static int zmk_rgb_underglow_init(const struct device *_arg) {
int zmk_rgb_underglow_save_state() { int zmk_rgb_underglow_save_state() {
#if IS_ENABLED(CONFIG_SETTINGS) #if IS_ENABLED(CONFIG_SETTINGS)
return k_work_reschedule(&underglow_save_work, K_MSEC(CONFIG_ZMK_SETTINGS_SAVE_DEBOUNCE)); int ret = k_work_reschedule(&underglow_save_work, K_MSEC(CONFIG_ZMK_SETTINGS_SAVE_DEBOUNCE));
return MIN(ret, 0);
#else #else
return 0; return 0;
#endif #endif

Loading…
Cancel
Save