Browse Source

address pr comments

xmkb
Kellen Carey 4 years ago
parent
commit
0b125c028c
  1. 2
      app/boards/shields/microdox/Kconfig.defconfig
  2. 3
      app/boards/shields/microdox/Kconfig.shield
  3. 5
      app/boards/shields/microdox/boards/nice_nano.overlay
  4. 7
      app/boards/shields/microdox/microdox.dtsi
  5. 14
      app/boards/shields/microdox/microdox.keymap
  6. 4
      app/boards/shields/microdox/microdox_left.overlay
  7. 4
      app/boards/shields/microdox/microdox_right.overlay

2
app/boards/shields/microdox/Kconfig.defconfig

@ -1,3 +1,5 @@
# Copyright (c) 2020 The ZMK Contributors
# SPDX-License-Identifier: MIT
if SHIELD_MICRODOX_LEFT if SHIELD_MICRODOX_LEFT

3
app/boards/shields/microdox/Kconfig.shield

@ -1,5 +1,4 @@
# Copyright (c) 2020 Pete Johanson # Copyright (c) 2020 The ZMK Contributors
# Copyright (c) 2020 Kellen Carey
# SPDX-License-Identifier: MIT # SPDX-License-Identifier: MIT
config SHIELD_MICRODOX_LEFT config SHIELD_MICRODOX_LEFT

5
app/boards/shields/microdox/boards/nice_nano.overlay

@ -1,3 +1,8 @@
/*
* Copyright (c) 2020 The ZMK Contributors
*
* SPDX-License-Identifier: MIT
*/
&spi1 { &spi1 {
compatible = "nordic,nrf-spi"; compatible = "nordic,nrf-spi";
/* Cannot be used together with i2c0. */ /* Cannot be used together with i2c0. */

7
app/boards/shields/microdox/microdox.dtsi

@ -1,6 +1,5 @@
/* /*
* Copyright (c) 2020 Pete Johanson * Copyright (c) 2020 The ZMK Contributors
* Copyright (c) 2020 Kellen Carey
* *
* SPDX-License-Identifier: MIT * SPDX-License-Identifier: MIT
*/ */
@ -43,10 +42,6 @@ RC(2,0) RC(2,1) RC(2,2) RC(2,3) RC(2,4) RC(2,5) RC(2,6) RC(2,7) RC(2,8) RC(2,9)
}; };
bt_unpair_combo: bt_unpair_combo {
compatible = "zmk,bt-unpair-combo";
};
// TODO: per-key RGB node(s)? // TODO: per-key RGB node(s)?
}; };

14
app/boards/shields/microdox/microdox.keymap

@ -27,14 +27,14 @@
}; };
nav_layer { nav_layer {
// ----------------------------------------------------------------------------------------- // -----------------------------------------------------------------------------------------
// | | | ESC | ~ | | | TAB | HOME | UP | END | DEL | // |BTCLR| | ESC | ~ | | | TAB | HOME | UP | END | DEL |
// | | GUI | ALT | CTRL | NUM | | / | LEFT | DOWN | RGT | BKSP | // | BT1 | GUI | ALT | CTRL | NUM | | / | LEFT | DOWN | RGT | BKSP |
// | | | | | | | \ | ENT | | | | // | BT2 | | | | | | \ | ENT | | | |
// | | | | | | | | // | | | | | | | |
bindings = < bindings = <
&trans &trans &kp ESC &kp TILD &trans &kp TAB &kp HOME &kp UARW &kp END &kp DEL &bt BT_CLR &trans &kp ESC &kp TILD &trans &kp TAB &kp HOME &kp UARW &kp END &kp DEL
&trans &kp GUI &kp RALT &kp LCTL &mo 3 &kp FSLH &kp LARW &kp DARW &kp RARW &kp BKSP &bt BT_SEL 0 &kp GUI &kp RALT &kp LCTL &mo 3 &kp FSLH &kp LARW &kp DARW &kp RARW &kp BKSP
&trans &trans &trans &trans &trans &kp BSLH &kp RET &trans &trans &trans &bt BT_SEL 1 &trans &trans &trans &trans &kp BSLH &kp RET &trans &trans &trans
&trans &trans &trans &trans &trans &trans &trans &trans &trans &trans &trans &trans
>; >;
}; };
@ -53,6 +53,8 @@
>; >;
}; };
// This layer is unreachable until "tri layer state" is sorted out.
// Leaving it here for completeness.
num_layer { num_layer {
// ----------------------------------------------------------------------------------------- // -----------------------------------------------------------------------------------------
// | | | | | | | A | 7 | 8 | 9 | D | // | | | | | | | A | 7 | 8 | 9 | D |

4
app/boards/shields/microdox/microdox_left.overlay

@ -16,7 +16,3 @@
, <&pro_micro_d 15 GPIO_ACTIVE_HIGH> , <&pro_micro_d 15 GPIO_ACTIVE_HIGH>
; ;
}; };
&bt_unpair_combo {
key-positions = <0 38>;
};

4
app/boards/shields/microdox/microdox_right.overlay

@ -20,7 +20,3 @@
, <&pro_micro_a 3 GPIO_ACTIVE_HIGH> , <&pro_micro_a 3 GPIO_ACTIVE_HIGH>
; ;
}; };
&bt_unpair_combo {
key-positions = <9 35>;
};

Loading…
Cancel
Save